PeculiarVentures / xmldsigjs / 41473786976

86%

push

github

feat(xmldsig): add canonicalization sign option (#157)

* feat(xmldsig): add canonicalization sign option

OptionsSign.canonicalization sets the SignedInfo CanonicalizationMethod.
It accepts the same names as reference transforms (c14n, exc-c14n,
c14n-com, exc-c14n-com) or an algorithm URI. The default stays c14n.

Closes #21

* fix(xmldsig): accept only canonicalization methods in the canonicalization option

The option resolved any transform, so values such as base64 or
enveloped were written to CanonicalizationMethod. With base64 the
signature covered only the DigestValue text, not the rest of SignedInfo.
Non-canonicalization transforms now throw ALGORITHM_NOT_SUPPORTED and an
empty value throws instead of falling back to the default.

* test(xmldsig): cover explicit c14n, custom C14N and comments in canonicalization option

* fix(xmldsig): keep custom canonicalization URI as given

A registered C14N subclass that does not override Algorithm was written as the built-in URI, so its own canonicalizer never ran on verify. Short names still map to the built-in URI; namespace URIs are kept as given.

1147 of 1527 branches covered (75.11%)

7 of 7 new or added lines in 1 file covered. (100.0%)

2278 of 2645 relevant lines covered (86.12%)

2106.3 hits per line