supabase / supabase / 41465414857

87%

push

github

fix(studio): give disk space warning plan-specific guidance (#52633)

The disk space warning banner showed every user the text "You can opt to
increase your disk size up to 200GB on the Database Settings page". That
text was wrong on three counts: 200 GB is the cap on a single automatic
expansion step, the disk settings now live on the Infrastructure page,
and it never mentioned that paid-plan disks already expand
automatically. Users who had just received the automatic resize email
couldn't tell what to do next.

**Changed:** I split the banner description by plan.
- **Paid plans**: the description says the disk expands automatically
and points to the Infrastructure page for its current size and any
limits on resizing it.
- **Free Plan**: the description says the disk doesn't expand
automatically and suggests freeing up space or upgrading.
- **Organization still loading**: the banner falls back to a
plan-neutral sentence, so a Free Plan project never flashes the paid
text.

**Note:** I left a manual-resize instruction out of the paid copy
because the Infrastructure page blocks manual resizing above 8 GB while
the spend cap is on, and blocks any resize during the cooldown after the
previous one. That page explains which case applies. Spend cap is not a
separate case because automatic expansion runs the same way with or
without it.

## To test
Setup: on a project's home page (the banner is hidden on Usage and
Infrastructure), override the `GET /platform/projects-resource-warnings`
response so the entry with `project: <ref>` has
`"disk_space_exhaustion": "warning"`. To check both plans with one org,
also override `GET /platform/organizations` to set the org's `plan.id`.

I tested on the PR preview:
- [x] Open a project in a paid organization, expect the banner
description "Your disk expands automatically as it fills up. The
Infrastructure page shows its current size and any limits on resizing
it." I observed this with the org forced to `pro`; the "Check... (continued)

1980 of 2350 branches covered (84.26%)

Branch coverage included in aggregate %.

2776 of 3134 relevant lines covered (88.58%)

196.3 hits per line