penguinolog / urwid / 41465346988

94%

Build Type

push

github

Committed by web-flow

Commit Message

Add readline keys, undo and a kill buffer to Edit (#1565)

* Add readline editing commands and CommandMap.bind_readline()

Edit handles four new commands, which no key is mapped to by default:

- "cursor line start" and "cursor line end" move to the ends of the line, which ends at a newline, not at the screen row edge.
- "delete space word left" deletes back to the previous whitespace, as bash's ctrl w does.
- "delete char right" does what the delete key does.

CommandMap.bind_readline() maps ctrl a/e, meta b/f, meta backspace/d, ctrl u/k, ctrl w and ctrl d to them:

- It binds on a copy and installs it only when no key is taken by another command.
- Only Edit handles these commands, so the keys reach a ListBox unhandled and the shared map can take them.
- The manual and the tour show an Edit subclass with its own copy of the map.

* Add undo and redo to Edit

Edit(undo_limit=n) keeps up to n changes made by keys; undo() and redo() take them back and make them again.

- The default limit is 0, so nothing is recorded unless the application asks for it.
- The new "undo" and "redo" commands call undo() and redo().
- bind_readline() maps ctrl _ to "undo".
- Consecutive typed characters are one step, and so is a run of backspace or of delete.
- Setting the text from the application clears the history, including a "submit" handler that clears the field.
- IntEdit and NumEdit strip leading zeros within the step of the key.
- An undo or redo key in IntEdit and NumEdit keeps the restored text as it was shown.

* Add a kill buffer and yank to Edit

Edit(kill_buffer=list) puts the text the word and line delete commands remove into the list; edits may share it.

- Consecutive kills in one edit join the newest entry: forward kills append, backward kills prepend.
- Any other key, a mouse event, a change from elsewhere, or a change of the list by someone else starts a new entry.
- A masked edit puts nothing into the list.
- The new "yank" command inserts the newest ... (continued)

Coverage Stats

6135 of 6874 branches covered (89.25%)

Branch coverage included in aggregate %.

194 of 197 new or added lines in 3 files covered. (98.48%)

9 existing lines in 1 file now uncovered.

15474 of 16670 relevant lines covered (92.83%)

15.56 hits per line