safe-global / safe-events-service / 41459092051

88%

Build Type

push

github

Committed by web-flow

Commit Message

feat: Upgrade NestJS to v12 (#660)

* feat: Upgrade NestJS to v12

- Bump @nestjs/* to v12 and TypeScript to 6.0 (pinned to ~6.0.3, typescript-eslint supports <6.1).
- Terminus v12: queue indicator uses HealthIndicatorService and returns down instead of throwing
  HealthCheckError, DB ping uses withTimeout(). Move QueueHealthIndicator to HealthModule.
- TS 6: module nodenext, strict on (except strictPropertyInitialization), explicit types,
  rootDir in build config, default imports for CJS packages.
- AdminJS: load the ESM-only packages with a real import() instead of eval.
- Admin login returns only the email, so the password is not stored in the session.
- ADMIN_COOKIE_SECRET and ADMIN_SESSION_SECRET are required at startup.
- Refresh transitive dependencies.

* fix: Do not return the database error in /health/ready

Terminus 12 pingCheck puts the driver error message in the result, which can expose hosts or ports. Log it and return a plain down.

* build: Enable isolatedModules

ts-jest warns (TS151002) when module is nodenext without isolatedModules. Cache is imported with import type (TS1272), and rootDir is set in the base tsconfig because ts-jest compiles each file on its own (TS5011).

* refactor: Move the database health check to DatabaseHealthIndicator

Same pattern as QueueHealthIndicator, so the controller is only the list of checks. No behaviour change.

Coverage Stats

435 of 522 branches covered (83.33%)

Branch coverage included in aggregate %.

40 of 44 new or added lines in 7 files covered. (90.91%)

1 existing line in 1 file now uncovered.

745 of 840 relevant lines covered (88.69%)

21.58 hits per line