IntelPython / dpnp / 41437916626

84%

push

github

Raise `KeyError` for an unknown key in array `flags` (#3141)

`flags[key]` on `dpnp.ndarray` and `dpnp.tensor.usm_ndarray` returned
`None` for any key it doesn't handle. That includes NumPy spellings such
as `"WRITEABLE"`, `"OWNDATA"` and `"ALIGNED"`. Because `None` is falsy,
NumPy-style checks gave a wrong answer instead of an error:

```python
import dpnp

a = dpnp.ones(3)
a.flags["WRITEABLE"]  # None, so `if not a.flags["WRITEABLE"]:` treats a writable array as read-only
```

`Flags.__getitem__` now raises `KeyError("Unknown flag")`, the same
error and message as NumPy. The supported keys are unchanged: `"C"`,
`"C_CONTIGUOUS"`, `"F"`, `"F_CONTIGUOUS"`, `"W"`, `"WRITABLE"`, `"FC"`,
`"FNC"`, `"FORC"` and `"CONTIGUOUS"`. `__setitem__` already rejected
unknown keys.

1604 of 2994 branches covered (53.57%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

29438 of 34570 relevant lines covered (85.15%)

17673.41 hits per line