supabase / supabase-flutter / 41417592519

94%

push

github

fix(postgrest): count the rows of a maybeSingle() read from Content-Range (#2113)

## What

Aligns the read side of `maybeSingle()` with the row counting defined in
https://github.com/supabase/sdk/pull/307.

A read or function call with `maybeSingle()` used to count the rows by
the length of a JSON array body, and ignored any other body. It now
takes the count from the range before the `/` in `Content-Range`:

- `*` is 0 rows, so it resolves to `null`.
- `{first}-{last}` is `last - first + 1` rows.
- Without a range in either form, it counts the elements of a JSON array
body, and any other body as one row.

More than one row throws the same 406 `PGRST116` exception as before,
and one row resolves to the single element of a one-element array, or to
the body itself. A `HEAD` request now goes through the same counting.

The read or write check that decides whether `maybeSingle()` sends the
object `Accept` header is now one getter. The parser uses the same
getter, so the two can no longer disagree.

## Note

`maybeSingle()` resolves to `PostgrestMap?`. A function returning an
array value, such as `RETURNS int[]`, is counted as one row as the spec
requires, but its array body cannot be cast to that type. The call used
to fail with a `PGRST116` for a multi-element array and now fails with a
cast error instead.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
<!-- coderabbit-ai-generated:v1 -->

## Summary by CodeRabbit

* **Bug Fixes**
* `maybeSingle()` now handles row counts consistently for reads and
function calls. It returns `null` when no rows match, returns the row
when exactly one matches, and reports an error when multiple rows are
found.
* Row counts are determined using response metadata when available, with
the response body as a fallback. Offset ranges and HEAD requests are
also handled correctly.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

22 of 22 new or added lines in 2 files covered. (100.0%)

12539 of 13321 relevant lines covered (94.13%)

6.64 hits per line