firezone / sanstun / 41363194067

93%

push

github

fix(handshake): clear all state after a handshake completes (#142)

The handshake code inherited from `boringtun` allows two handshakes to
be in progress at any given time. This is important for links with an
RTT > 5s (and thus > `REKEY_TIMEOUT`) because it ensures that we can
establish a session even if we receive a response to a previous
initiation after having already sent another one.

What the code got wrong is that only ever the matched handshake state
got cleared and the unmatched one was still retried after
`REKEY_TIMEOUT`.

We now clear all pending handshake initiations as soon as we receive a
matching handshake response, including a scheduled handshake queued by a
timer.

---------

Co-authored-by: Thomas Eizinger <thomas@eizinger.io>

9 of 9 new or added lines in 3 files covered. (100.0%)

2077 of 2231 relevant lines covered (93.1%)

57051.89 hits per line