• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

starwing / lua-protobuf / 41320810709
99%

Build:
DEFAULT BRANCH: master
Ran 01 Nov 2026 03:21PM UTC
Jobs 6
Files 2
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

01 Nov 2026 03:20PM UTC coverage: 99.583% (-0.07%) from 99.655%
41320810709

push

github

starwing
style: shrink long signatures, compact bodies, fix analyzer findings

Follow-up to 4e9edf0: the 80-column pass left the signatures that
clang-format cannot break, and this commit reworks them instead of
folding lines, keeps the compact single-statement style where it fits,
and makes clang-analyzer clean.

Signature rework:

- drop the redundant pb_State/lpb_State parameters from the encode,
  decode and loader helpers (callers always pass lpb_lstate(L) or L->S,
  now derived inside);
- pass `int proto3` instead of `const pb_Type *` to the encoder helpers,
  and shorten pb_newfield's parameters (`fname`/`number` -> `fn`/`n`);
- bundle the slice-unpack cursor in `lpb_Unpack`, split `lpb_checkfmt`
  out of `lpb_packfmt`, rename `rangerelat` to `getrange`, and let
  `lpb_pushunpackdef` recompute its sorted field list.

.clang-format now indents preprocessor directives after `#`, reflows
comment indentation, sorts includes, formats macro bodies, and uses
`BinPackParameters: BinPack`.  The commented-out cache branch in
pb_newname moves to its own line so the file has a clang-format fixed
point.  CMakeLists.txt calls cmake_minimum_required before project.

Deliberate behavior changes:

- pb_readvarint32/64 and both fallbacks store 0 into *pv on failure
  (the error paths never return, but the analyzer cannot see that).
- buffer:pack validates the format before packing, so an invalid format
  reports the structure error before an argument error; successful
  encodings are unchanged.
- slice:unpack("+", n) clamps the target to >= 1 instead of == 0, so a
  large negative offset no longer computes a pointer before the slice.
- lpb_pushunpackdef is static again: it was never declared in pb.h, so
  pb.so now exports only the documented lpb_* helpers.

Analyzer fixes, all behavior neutral: return the error helpers' result;
build the unsafe slices only after the NULL check (pb.unsafe.load
really did compute NULL + size); tie pb_nextentry's size to a non-NULL
hash; c... (continued)

405 of 405 new or added lines in 2 files covered. (100.0%)

8 existing lines in 2 files now uncovered.

1909 of 1917 relevant lines covered (99.58%)

5323.04 hits per line

Coverage Regressions

Lines Coverage ∆ File
7
99.03
-0.04% pb.h
1
99.92
-0.08% pb.c
Jobs
ID Job ID Ran Files Coverage
1 run-5.5.0 - 41320810709.1 01 Nov 2026 03:21PM UTC 2
99.57
GitHub Action Run
2 run-luajit-openresty - 41320810709.2 01 Nov 2026 03:22PM UTC 2
99.58
GitHub Action Run
3 run-5.3 - 41320810709.3 01 Nov 2026 03:22PM UTC 2
99.57
GitHub Action Run
4 run-5.2 - 41320810709.4 01 Nov 2026 03:21PM UTC 2
99.57
GitHub Action Run
5 run-5.4.8 - 41320810709.5 01 Nov 2026 03:22PM UTC 2
99.57
GitHub Action Run
6 run-5.1 - 41320810709.6 01 Nov 2026 03:21PM UTC 2
99.58
GitHub Action Run
Source Files on build 41320810709
  • Tree
  • List 2
  • Changed 2
  • Source Changed 0
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 04de7835 on github
  • Prev Build on master (#28603515184)
  • Next Build on master (#41321898727)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc