kubernetes-sigs / lws / 41306245064

88%

Build Type

push

github

Committed by web-flow

Commit Message

fix: report Ready only after the webhook server starts (#1261)

lws-controller-manager registers readyz as `healthz.Ping`, but it sets
up the webhooks only after the certs are ready. So a replica can go
Ready, and the Deployment Available, before it serves webhook calls.
Creating a LeaderWorkerSet right after the Deployment is Available can
then fail with `connection refused`.

setupControllers now closes a `webhooksReady` channel after it
registers the webhooks. The readyz check waits for that channel and
then runs the webhook server's `StartedChecker`. So readyz is never the
first caller of `GetWebhookServer()`, which would start a webhook
server with no webhooks. When `ENABLE_WEBHOOKS=false`,
lws-controller-manager sets up no webhook server, so readyz stays
`healthz.Ping`.

Coverage Stats

12 of 19 new or added lines in 1 file covered. (63.16%)

3 existing lines in 1 file now uncovered.

9297 of 10535 relevant lines covered (88.25%)

36803.36 hits per line