solidjs / solid / 41292604375

78%

main: 89%

push

github

fix(signals): prod getContext with no owner reads the context default (#4586)

In the production build, a component created outside any owner (module-scope
JSX, a timer, after an await) threw NoOwnerError from useContext even when the
context had a default; dev and observe returned the default because their
createComponent wraps each component in a root.

Fix it at the read instead of adding a root to prod createComponent: with no
owner, prod getContext now reads as if under an empty root (the default, else
ContextNotFoundError), matching what dev gives that component. Dev keeps
NoOwnerError for a bare no-owner read. createComponent is unchanged, the owned
read does the same work, and the minified getContext is a few bytes smaller.

Tests port brenelz's no-owner context-default cases (#4565): per-tier cases
against the signals prod/observe/dev artifacts, and the observe/dev and
prod-under-owner cases in solid's client artifact spec.



Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Brenley Dueck <brenleydueck@gmail.com>

797 of 1098 branches covered (72.59%)

Branch coverage included in aggregate %.

1129 of 1367 relevant lines covered (82.59%)

30.05 hits per line