solidjs / solid / 41291059624

78%

main: 89%

push

github

fix(signals): list-identity diagnostic reads only own data id/key/_id (#4583)

recordId read `id ?? key ?? _id` through getters, so pairing rows for
UNSTABLE_LIST_IDENTITY could run user code (the same issue #4548 fixed for
shallowEquivalent). It now reads own data properties only; a prototype or own
accessor `id` is not treated as identity. shallowEquivalent folds onto the
same ownData helper and compares arrays by own keys (indices and length), so
holes and accessors behave as before.


Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

Co-authored-by: Claude <noreply@anthropic.com>

797 of 1098 branches covered (72.59%)

Branch coverage included in aggregate %.

1129 of 1367 relevant lines covered (82.59%)

30.04 hits per line