solidjs / solid / 41279959181

78%

main: 89%

push

github

fix(signals): a re-parked node drops pending sources its pass no longer reaches (#4541) (#4546)

* fix(signals): a re-parked node drops pending sources its pass no longer reaches (#4541)

A node that re-parks kept every source the earlier pass carried, because the
pass's own throw adds to that same set and the #3456 sweep compared the set to
itself. An async memo whose first flight was superseded by a synchronous answer
stages that answer (uninitialized until its commit), so its own settle walk
waits; its readers re-derive clean, but a node beyond them that re-parked on
another source kept the copy and waited on it forever. Judge reachability by
the deps (retryReaches) instead.

Fixes #4541.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* fix(signals): decide the re-park sweep by deps alone, no extra core bytes (#4541)

The pass's own throw adds to the set it carried, so the has() check was
always true on the notReady path and always false on the stagedErr path.
retryReaches decides the first; a staged error settles all it carried.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* fix(signals): keep the re-park sweep's carried check; share hasPendingSource (#4541)

931aa77 decided the sweep by deps alone, but a re-park can replace the
set: a source the node no longer carries must still retire from its
dependents even when a dep holds a copy (lane-contract nested guess).
Settle when the node no longer carries the source OR no dep reaches it.
The pending-source membership read becomes one shared helper, which
pays for the extra check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* perf(size): share the cold-path in-flight clear (offsets #4541's sweep check)

The disposal and loading-window sites clear a nod... (continued)

797 of 1098 branches covered (72.59%)

Branch coverage included in aggregate %.

1129 of 1367 relevant lines covered (82.59%)

29.89 hits per line