graphty-org / graphty-monorepo / 41269717488

92%

Build Type

push

github

Committed by github-actions[bot]

Commit Message

fix(compact-mantine): menu buttons with a tooltip keep aria-expanded and the open look

A Tooltip placed between Menu.Target and its button took the aria-expanded,
aria-controls, aria-haspopup and id that Menu.Target writes on its child and
put them on its floating label, so the button never drew compact-mantine's
open style and a screen reader was never told the menu was open.

compact-mantine gains TargetTooltip (additive export, plus TargetTooltipProps):
a Mantine Tooltip that hands those attributes to the button. SplitButton uses
it instead of writing the ARIA by hand. Every graphty menu button that had a
Tooltip inside Menu.Target now uses it: the group row actions (Groups.tsx),
Main menu (frame/menus.tsx), Add source, Add filter, Add a table (DataPage),
the style tree's add row, Graph settings' background add, the inspector's
actions, the label card's actions and the style section's add menu.

Refs #5345
Fixes #5357

Coverage Stats

121057 of 137186 branches covered (88.24%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 6 files covered. (100.0%)

16 existing lines in 5 files now uncovered.

165041 of 173979 relevant lines covered (94.86%)

463437.03 hits per line