solidjs / solid / 41251192932

78%

main: 89%

push

github

fix(signals): a pending memo nothing reads holds no fresh Loading under a held mount (#4542) (#4554)

* fix(signals): a pending memo nothing reads holds no fresh Loading under a held mount (#4542)

A first pass that reads a held node and is left pending is held with the
hold (its answer is the hold's, and a render effect that reads it joins).
The trailing block also offered it to `freshHook`, so a fresh <Loading>
caught the memo as a reader and stayed on its fallback until it settled,
forever for a memo that never does, though no render effect reads it.

Only an effect is caught now. A derivation left pending is held but
reaches no boundary (Reader, D-12: membership is the render effect's
position), and the commit waits for it only through a render effect that
reads it (`blockedBy`). The #3540 reader counts drop the memo accordingly:
in flight the memo content now counts as its binding alone, as held did.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* test(web): import JSX from @solidjs/web in the #4542 spec

solid-js does not export the JSX type, so @solidjs/web#test-types failed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

---------

Co-authored-by: Claude <noreply@anthropic.com>

797 of 1098 branches covered (72.59%)

Branch coverage included in aggregate %.

1129 of 1367 relevant lines covered (82.59%)

30.07 hits per line