karpetrosyan / hishel / 41221957329

98%

push

github

fix: preserve repeated header fields like Set-Cookie (#494)

* fix: preserve repeated header fields like Set-Cookie

Multi-value header fields were collapsed into a single comma-separated
value whenever headers crossed a conversion boundary or were rebuilt
into a new Headers object, so e.g. two Set-Cookie fields became one
unparseable string. Headers already stores one value list per field
name; use multi_items() and the underlying mapping instead of the
Mapping items() view so the lists survive intact.

* fix: preserve ASGI request headers across case variants

Normalize ASGI request header names before collecting repeated values. Add a regression test for repeated request headers with different name case.

---------

Co-authored-by: Kar Petrosyan <92274156+karpetrosyan@users.noreply.github.com>

118 of 119 new or added lines in 12 files covered. (99.16%)

4801 of 5292 relevant lines covered (90.72%)

4.54 hits per line