renatahodovan / grammarinator / 41203107831

84%

Build Type

push

github

Committed by web-flow

Commit Message

Fix rule name lookup in Python regenerate_rule (#412)

The keys of Annotations.rules_by_name are 1-tuples of rule names, but
regenerate_rule used them as is to look up rule sizes, which are keyed by
plain rule names. So, every lookup failed (logging "Unknown rule name in
generation"), and the mutator could never regenerate any node.

The bug was hidden from type checking by the type annotations of
Annotations, which declared the keys of its dictionaries as strings. Now
they declare tuples.

Coverage Stats

7 of 7 new or added lines in 2 files covered. (100.0%)

4 existing lines in 1 file now uncovered.

2298 of 2754 relevant lines covered (83.44%)

0.83 hits per line