solidjs / solid / 41186796155

78%

main: 89%

push

github

fix(signals): an effect's error boundary keeps no superseded staged error (#4527) (#4533)

* fix(signals): an effect's error boundary keeps no superseded staged error (#4527)

Here is the case: an action re-asks a derived store and a memo, so its
transition stays open. The store's re-ask is rejected (staged, D-41), and a
second re-ask answers before the commit. An effect that created
`createErrorBoundary(() => store, ...)` in its compute got the fallback at
the commit and never ran again.

- store: handleAsync's untracked shape probe of a returned proxy pulls the
  derive. When that pull throws a staged error, it now links the pass, as a
  tracked read does (#4519). The memo carries the error and stays reachable
  by the re-ask and the answer that supersede it.
- boundaries: prune's "fresh boundary keeps its fallback until the reader
  commits" clause (#3540) applies to loading boundaries only. In an error
  boundary, a recovery that lands in the hold that staged the error joins
  that hold and reveals with its commit (D-39, D-41).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* fix(signals): trim the #4527 fix by 11 B minified on store rows, 4 B elsewhere

- store: link the pass the staged error is thrown into whether the pull is
  tracked or not (a tracked read links anyway, and `link` dedupes). This
  drops the `tracking` test, and `c &&` replaces `c !== null`.
- boundaries: an error boundary is born `_initialized` (the field is
  loading-only: no other error-boundary path reads it), so prune's #3540
  clause stays as it was.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

---------

Co-authored-by: Claude <noreply@anthropic.com>

797 of 1098 branches covered (72.59%)

Branch coverage included in aggregate %.

1129 of 1367 relevant lines covered (82.59%)

29.93 hits per line