agronholm / cbor2 / 41185223149

96%

Build Type

push

github

Committed by web-flow

Commit Message

Isolate string references in encode_to_bytes from the outer namespace (#356)

Strings encoded via encode_to_bytes() were registered in the string reference namespace of the enclosing encode operation. When called from a default hook, this had two consequences:

- a string returned by the hook could later be emitted as a string
  reference that the decoder then resolved to the wrong value (or failed
  to resolve at all), since the decoder's namespace indexes only the
  values actually written to the outer stream
- the bytes returned by the hook could contain string references that
  index the outer namespace, making them impossible to decode as the
  standalone CBOR item the method promises to return

Give the nested encoding a namespace of its own instead, mirroring how encode_semantic() sets the outer namespace aside for a tag 256 value.

---------

Co-authored-by: Z User <z@container>
Co-authored-by: 17krishna8 <17krishna8@users.noreply.github.com>

Coverage Stats

13 of 13 new or added lines in 1 file covered. (100.0%)

10 existing lines in 1 file now uncovered.

2514 of 2643 relevant lines covered (95.12%)

81960.65 hits per line