umputun / reproxy / 41184042456

81%

Build Type

push

github

Committed by web-flow

Commit Message

fix: throttle before auth, plugin request fields, bounded metrics label, host parsing (#271)

* fix: throttle before auth, give plugins the matched request, bound metrics server label

rate limits ran after global and per-route basic auth, so requests with
wrong credentials never counted and password guessing was unlimited. The
limiters now run right after the IP allowlist.

plugins got the client's raw path spelling, an empty Host for ordinary
origin-form requests and the X-Real-IP header as the client sent it. A plugin rejecting /fail let
/%66ail through to the upstream as /fail, and could be fed any client
address. Plugins now get the canonical path, the request host, and
X-Real-IP resolved through --trusted-proxy.

with --mgmt.low-cardinality the server label still took the raw Host, so
each new Host value added a series. It now uses the matched route's
server, or [unmatched].

the host port was cut with a split on ":", which turned [::1]:8080 into
"[" in route matching and metrics. It is now parsed with url.URL.

* fix: keep the server name of a Host with a non-numeric port

url.URL.Hostname strips a port only when it is all digits, so a Host like
ADMIN.example.com:x or a.example.com:x kept the suffix and missed its exact
and wildcard servers. The request fell through to a catch-all route and
skipped the narrower rule's auth and allowlist. Route matching, the plugin
Host field and the metrics server label now share discovery.HostName,
which cuts at the first colon as before and only unwraps bracketed IPv6.

the README plugin intro no longer calls the plugin URL the original one.

* fix: take the server name from r.Host for absolute-form targets too

route matching preferred r.URL.Hostname for absolute-form targets. For a
non-http scheme Go splits that host at the last colon, so
GET foo://a.wild.example:1:2/x gave "a.wild.example:1", missed its
wildcard server and reached the catch-all without that rule's auth. Go's
server already copies the targe... (continued)

Coverage Stats

26 of 26 new or added lines in 5 files covered. (100.0%)

1 existing line in 1 file now uncovered.

2628 of 3239 relevant lines covered (81.14%)

78.29 hits per line