solidjs / solid / 41181882384

78%

main: 89%

push

github

feat(signals): dev diagnostic CAUGHT_REACTIVE_READ — a reactive read's throw caught and the pass completed (D-42) (#4481)

* feat(signals): dev diagnostic CAUGHT_REACTIVE_READ — a reactive read's throw caught and the pass completed (D-42)

A reactive read's throw (NotReadyError or the source's error) is addressed
to the graph: try/catch around it is not a channel (D-42 / S-47). This
detects the detectable half — a computation's pass completed normally after
a reactive read threw into it — and warns once per computation, dev only.

Mechanism: read()/serve()/verdict throw sites record the throw against the
running pass in a module-level WeakMap; recompute clears the record at the
pass head and judges it when _fn returns. A body that returned a flight
(thenable / async iterable) is judged when the flight settles: a rejection
is the throw continuing (an async function converts a pre-await throw into
its rejection), a landed value is the catch. The runtime's own catches —
boundary output and `on`, isPending's probe, watch's error arm, comparator,
cleanup and effect-callback routing, solid-js's hydration trace and
Dynamic's warm-up — forget the record. Zero production bytes (size harness
byte-identical across all 22 scenarios).

Co-authored-by: Cursor <cursoragent@cursor.com>

* docs(signals): CAUGHT_REACTIVE_READ error arm — errored regardless by the rules (F-12/#4410); today's runtime may complete with the caught value until the source is retried (#4486)

Co-authored-by: Cursor <cursoragent@cursor.com>

* test(signals): treeshake suite gets a 30 s hang guard — each case runs a Vite build; CI's first bundle went past vitest's 5 s

Co-authored-by: Cursor <cursoragent@cursor.com>

* test: pin the #4342 query-cache shape as a CAUGHT_REACTIVE_READ true positive; note it at the web spec's catch

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Claude <noreply@anthropic.com>

797 of 1098 branches covered (72.59%)

Branch coverage included in aggregate %.

2 of 3 new or added lines in 2 files covered. (66.67%)

1129 of 1367 relevant lines covered (82.59%)

29.95 hits per line