solidjs / solid / 41176015101

78%

main: 89%

push

github

fix(babel-plugin): keep a returned element's setup inside a braceless if or loop body (#4450)

Statement-position JSX inserts its setup before `getStatementParent()`.
That helper skips statements outside a statement list, so for
`if (c) return <span>{x.join()}</span>;` it returned the whole `if`: the
template clone and `insert` ran when `c` was false, a loop body's setup read
its loop variable out of scope, and a hydrating `getNextElement` claimed a
node for a branch not taken. Insert before the `return` itself instead;
Babel wraps the body in a block. Applies to the DOM, universal and SSR
templates. Existing fixture outputs are unchanged.

Co-authored-by: Ryan Carniato <ryansolid@gmail.com>

791 of 1090 branches covered (72.57%)

Branch coverage included in aggregate %.

1127 of 1364 relevant lines covered (82.62%)

29.94 hits per line