solidjs / solid / 41174085072

78%

main: 89%

push

github

fix(signals): link a store reader to its derive's staged error (#4517) (#4519)

* fix(signals): link a store reader to its derive's staged error (#4517)

A derive marked with a staged error (`stageMark`, #4456) carries no
STATUS_ERROR until the commit, so `pullFamily` took it for a settled
derive and pulled it untracked. The pull threw the staged error before
the reader read any leaf, so the reader subscribed to nothing in the
family: when the derive's source re-asked and landed, neither the wake
nor the settle reached it. An `<Errored>` mounted in the change that
errored its content stayed on its fallback over a keyed
`createProjection`, while the same read of the memo recovered.

A reader now links to a derive carrying a staged error as it does to a
pending or errored one, and re-runs at the landing. The render-effect
early return in that branch is for a derive with a flight up only: a
staged error is an answer the frame reader has to meet (D-41; the #3887
pin).

Pins: packages/signals/tests/errored-born-staged-error-projection-4517.test.ts,
packages/web/test/errored-born-staged-error-projection-4517.spec.tsx
(the issue's repro).

Size: +8 to +10 B minified on the store scenarios, every one under its
brotli cap; the three over-cap warnings are +0 B over next.

* fix: address review findings

The pullFamily comment block keeps its original lines, with one line on
the staged-error pull in place of the three that narrated the issue.
The web spec's header keeps only the jsxImportSource and
vitest-environment pragmas, as the neighbouring specs do. The changeset
states the behavior that changed in two sentences.

790 of 1090 branches covered (72.48%)

Branch coverage included in aggregate %.

1126 of 1363 relevant lines covered (82.61%)

29.67 hits per line