solidjs / solid / 41141927039

78%

main: 89%

push

github

fix(signals): four optimistic store bugs (#4480, #4489, #4482, #4484) (#4511)

* fix(signals): an error boundary a held pass mounts over a staged error settles (#4480)

boundarySeam's fold-back (D-16, U-9: a fallback staged into the hold its
readers landed in is content-ready at that hold's commit) ran for error
boundaries too. What an error boundary still waits on after `prune` is an
error staged into the hold (D-41), not a landing: clearing its readers
redrew the output, which met the staged error again, set the error signal
and produced a new output — and the held effect that owns the boundary
re-ran on it, mounting a fresh one, forever ("Potential Infinite Loop
Detected ... last staged node: effect").

The fold-back is now a loading boundary's only. The error is an answer
staged with the frame (D-41, F-12): the held frame keeps what it showed and
the error fallback reveals with the hold (F-1, F-2).

Not optimistic-specific: any held pass (an effect re-run under a
transition's hold) that mounts createErrorBoundary over a memo whose
rejection is staged in that hold hung. The #4480 shape reaches it through
the D-34 hold of a filter change behind a pending guess.

Pins: packages/signals/tests/errored-held-mount-staged-error-4480.test.ts
(the general shape), packages/web/test/optimistic-reask-error-effect-boundary-4480.spec.tsx
(the issue's repro).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* fix(signals): a derived store's held rejection is staged with its frame (#4489)

handleAsync published any rejection of a node with a setter (only a
projection's derive passes one) at once, skipping D-41's staging. The
store's effect and the screen still waited (their held passes), but an
untracked read of a leaf pulled the errored derive and threw the new error
while the screen still showed the rows: a click handler on a held row
crashed (#4489, with an optimistic removal guess... (continued)

790 of 1090 branches covered (72.48%)

Branch coverage included in aggregate %.

1125 of 1362 relevant lines covered (82.6%)

29.82 hits per line