NVIDIA / nodewright / 41135167560

84%

Build Type

push

github

Committed by web-flow

Commit Message

fix(operator): keep a package's own interrupt and close the config-update completion gaps (#887)

* fix(operator): keep a package's own interrupt after a config change

A config change records its keys for the whole NodeWright, and with keys
present HasInterrupt consulted only the configInterrupts matching them. A
package whose own interrupt never ran on a node (for example a reboot that
was failing) then completed at config without it and the node was
uncordoned, or a newly selected node or a node reset after a config cycle
skipped it for the same reason.

Track the owed interrupt per node and package in PackageStatus
(interruptPending): set at apply or upgrade for a package that declares an
interrupt, cleared at post-interrupt. While set, HasInterrupt and the
interrupt merge add the package's own interrupt to the matching
configInterrupts, and the existing priority picks the winner. Entries
written before the field existed read as not pending, so no migration is
needed and an upgrade does not re-run anything. package rerun and
update-state set or clear the flag when they write apply, upgrade or
post-interrupt.

Part of #776

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Noah Kontur <nkontur@nvidia.com>

* fix(cli): set interruptPending only for packages that declare an interrupt

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Noah Kontur <nkontur@nvidia.com>

* fix(cli): clear interruptPending when package rerun targets post-interrupt

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Noah Kontur <nkontur@nvidia.com>

* fix(operator): clear interruptPending once the interrupt completes; cover the controller wiring

A config reset at (interrupt, complete) kept the flag, so the package's own
interrupt (a reboot, say) ran a second time on a node that had just run it.
Clear the flag at (interrupt, complete), in ProgressSkipped, and in
update-state. Pick the per-node interrupt th... (continued)

Coverage Stats

117 of 129 new or added lines in 8 files covered. (90.7%)

2 existing lines in 1 file now uncovered.

10398 of 12387 relevant lines covered (83.94%)

7.69 hits per line