• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

umputun / agterm / 41134507753
94%

Build:
DEFAULT BRANCH: master
Ran 30 Oct 2026 10:02PM UTC
Jobs 1
Files 228
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

30 Oct 2026 09:55PM UTC coverage: 94.791% (-0.004%) from 94.795%
41134507753

push

github

web-flow
feat(links): show a cmd-clicked image path in a session overlay (#844)

* feat(links): show a cmd-clicked image path in a session overlay

a cmd-click on a path printed in a pane did nothing unless it was a file://
link, which only revealed in Finder. A local png, jpg, gif or webp path, bare
or file://, now opens over its session in a panel shaped like the picture:
scaled up to 240 points wide when narrower, down to 80% of the session when
larger. Any other local path reveals in Finder. A pane attached from another
Mac ignores bare paths, since they name files on that Mac.

The page embeds the file as a data URI, with page JavaScript disabled and no
file grant or bridge, and never goes to a presenting Mac. The file is read
through one descriptor checked with fstat against the 64 MB cap, so a symlink
is measured at its target and a FIFO, device or offloaded iCloud file is
refused. Only a real PNG, JPEG, GIF or WebP signature reaches ImageIO, and a
header over 100 megapixels is refused. A click and a page load read off the
main actor. Control requests remain synchronous.

`session overlay open --image FILE` opens the same page from the control API.
ControlServerLinkOverlayTests now stops its server in teardown, which leaked a
lock descriptor per test.

* fix(control): let the accept loop close its own listener

`stop()` closed the listening socket while the accept loop could still be
inside `handleConnection`. The next server could reuse that descriptor number,
and the stale loop then accepted that server's connections or retried accept
on a lock file. 60 iterations of the queue and bind/stop tests logged 118
calls to accept begun after that server's close completed.

`ControlAcceptLoop` now owns the listener: `stop()` only wakes it through a
pipe, and the loop closes the socket itself after it exits. `shutdown()`
cannot be the wake, since on a listening Unix socket it fails with ENOTCONN
and leaves accept parked, so the loop waits in `poll` on the list... (continued)

97 of 102 new or added lines in 10 files covered. (95.1%)

18396 of 19407 relevant lines covered (94.79%)

3542128.17 hits per line

Uncovered Changes

Lines Coverage ∆ File
5
96.38
-3.62% agtermCore/Sources/agtermCore/HtmlOverlay.swift
Jobs
ID Job ID Ran Files Coverage
1 41134507753.1 30 Oct 2026 10:02PM UTC 228
94.79
GitHub Action Run
Source Files on build 41134507753
  • Tree
  • List 228
  • Changed 9
  • Source Changed 9
  • Coverage Changed 7
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #41134507753
  • 4cfb58c8 on github
  • Prev Build on master (#41130383023)
  • Next Build on master (#41158285542)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc