mongodb-js / devtools-shared / 41116774953

80%

main: 80%

Build Type

Pull #946

github

Committed by autarch

Commit Message

fix(mongodb-runner): keep server logs after `mongodb-runner start` exits

With `--logDir` set, each server's stdout and stderr were piped through the runner process into the
log file. `mongodb-runner start` exits once the cluster is up, so nothing wrote to those files
afterward and every log ended at startup.

This redirects the server's stdout and stderr straight to the log file instead, so the server keeps
logging on its own. The runner follows the file to read the startup output (port and build info)
that it previously got from the pipe.

Log files are now named `<binary>-<uuid>-<timestamp>.log` rather than using the pid, since the pid
isn't known before the file has to exist.

stderr now shares the file the runner parses, so lines that aren't log entries (for example docker's
"Unable to find image") are skipped instead of ending the log stream and failing startup.

Pull Request Pull Request #946: fix(mongodb-runner): keep server logs after `mongodb-runner start` exits

Coverage Stats

2229 of 3060 branches covered (72.84%)

Branch coverage included in aggregate %.

55 of 56 new or added lines in 3 files covered. (98.21%)

24 existing lines in 1 file now uncovered.

4751 of 5634 relevant lines covered (84.33%)

734.14 hits per line