solidjs / solid / 41092130438

78%

main: 89%

push

github

fix(signals): a Loading fallback is born held only when the output that builds it read the hold (#4428) (#4464)

* fix(signals): the fallback memo's born-held test asks the output that builds it (#4428)

`fallback()` builds the boundary's fallback memo beside the output,
`runWithOwner(out._parent, () => computed(...))`, while the output's own
pass runs. The memo's first pass ran at creation, in the output's owner, so
the born-held test at its close (`creatorPass(oldcontext)` JOINED) read the
enclosing pass's flag: under a mount that read the hold, the fallback was
born held though the pass creating it, the output, read nothing held.

Create the memo lazy. Its first pass runs in the output's `read(b._fb)` just
below, in the output's context, so born held asks the output (D-27, one
level: "a node it creates during that pass"). It stays owned by
`out._parent`, so the walk over running owners for #4341 is unchanged.
CONFIG_AUTO_DISPOSE, which `lazy` sets, is cleared: the fallback lives
until `drop()` disposes it, as before.

Fixes #4428

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* chore: keep the #4425 spec as next has it (undo the merge's formatter pass)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* fix(signals): leave the lazy fallback memo's auto-dispose as lazy sets it (#4428)

Drop the CONFIG_AUTO_DISPOSE clear: the fallback memo's one reader is the
output, and the output stops reading it only where `drop` disposes it or a
held swap commits, so the release lands with the disposal it already had.
The clear cost 9 B minified and reshuffled the prop mangler's names across
every bundle (±50–100 B brotli with 0 B minified on scenarios without a
boundary).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* ... (continued)

790 of 1090 branches covered (72.48%)

Branch coverage included in aggregate %.

1125 of 1362 relevant lines covered (82.6%)

29.82 hits per line