solidjs / solid / 41081734550

78%

main: 89%

push

github

fix(signals): close the probe's state around a memo isPending pulls (#4429) (#4465)

* fix(signals): close the verdict window's state for a memo it pulls (#4429)

`verdictValue` pulls a dirty memo with the dispatch closed (`setVerdict(null)`,
A31: the pulled memo's pass is its own) but left `probing` and
`latestActive` set. A `latest()` / `isPending()` the pulled memo made itself
re-entered the window with the outer probe's state:

- `latest()` of a born-held node took the probe's `joinPass` arm, so the
  memo's pass joined the hold and its value was held with it;
- a flight its `latest()` read set `probeFound`, so the outer `isPending`
  answered for the memo's reads, not for the memo;
- inside `latest(fn)`, the memo's own `isPending` of a held write read as a
  probe inside a `latest` window and answered final.

Each depended on who woke the memo. Save and clear both flags around the
pull, as the dispatch already is. `probeFound` needs no save: it is only
set while `probing`.

Fixes #4429

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* fix(signals): close only the probe's state around a pulled memo (#4429)

Narrow the fix to `probing`, the state #4429 names: +9 B brotli / +13 B
minified on `+ isPending/latest`, where clearing `latestActive` too cost
+25 / +25. `latestActive` leaks the same way (inside `latest(fn)`, a pulled
memo's own `isPending` of a held write answers final); that is left for
its own issue and decision.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* chore: keep the #4425 spec as next has it (undo the merge's formatter pass)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* chore(size): raise the compiled live page's cap for #4429 (+13 B minified)

Co-Authored-By: Claude Opus 5.5 <nore... (continued)

790 of 1090 branches covered (72.48%)

Branch coverage included in aggregate %.

1125 of 1362 relevant lines covered (82.6%)

29.76 hits per line