kubernetes-sigs / lws / 41078783264

88%

push

github

Avoid uncached unstructured GETs in findDelegatedWorkload (#1256)

* Avoid uncached unstructured GETs in findDelegatedWorkload

controller-runtime's default client does not cache runtime.Unstructured
objects (Client.Cache.Unstructured is false), so calling client.Get with
*unstructured.Unstructured in KubernetesProvider.findDelegatedWorkload
bypassed the informer cache and issued live kube-apiserver GETs on every
LWS and gated leader Pod reconcile whenever:
1. a 1-hop external parent's Workload was not yet created or synced to
   cache (which also failed with 403 Forbidden since manager-role has
   no RBAC for third-party kinds), or
2. the controller-owner chain had an intermediate hop such as
   ExternalParent -> DisaggregatedSet -> LeaderWorkerSet.

Follow intermediate controller owners only when they are cached in-tree
kinds covered by manager-role RBAC (DisaggregatedSet) using a typed
client.Object, and stop without issuing a GET on external or non-cached
owners. Also guard against cycles in controller-owner references.

Part of #1255

* Bound the delegated owner walk by hop count; fix core-group test owner

13 of 13 new or added lines in 1 file covered. (100.0%)

9283 of 10519 relevant lines covered (88.25%)

36859.33 hits per line