solidjs / solid / 41069156011

78%

main: 89%

push

github

fix(signals): a merged transaction's verdict lane is the same hold's at the D-28 seat (#4427) (#4455)

* fix(signals): D-28's verdict-seat reset compares holds, not verdict lane objects (#4427)

`laneRead`'s D-28 reset (#4275, #4284) makes a leaf seated as a hold's
verdict reader leave the seat when it reads a lane that is not that
hold's. It decided that by lane identity (`passLane !== l`). A
transaction merged into the hold keeps its own verdict lane: a
derivation stamped before the merge stays in it. So the leaf read that
lane as another hold's. It was served the derivation's staging as the
hold's own work (L7'), and its run waited for the hold's landing while
the derivation it read was already on screen.

The reset now compares the holds. It leaves only when the node is in
flight and has never shown, when the lane is not a verdict lane, or when
the lane's parent resolves to a different hold than the seat's (D-4:
merged holds are one). The seated leaf then reads that lane as the
hold's own: the lane's value, the two lanes linked by `enterLane` as for
any pass that reads both.

Fixes #4427

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* chore(size): record #4427's cost on the live server-component pages; golf readsHeld's loop

`readsHeld` (#4449) now walks its deps as `retryReaches` does
(`for (let d = r._deps; d; d = d._nextDep)`), which saves 7 B minified
on isPending/latest.

Measured locally (linux) over next @ 7135a77a. On page: live server
components (a frozen floor): 38,764 B brotli / 117,272 B minified, +45 B
minified, so the cap goes 38.76 -> 38.78 KB and floor-caps.json's
recorded minified 117,227 -> 117,272. On page: compiled live server
components: 42,690 / 125,414, so the cap goes 42.67 -> 42.70 KB and the
recorded minified 125,374 -> 125,414. Caps are at measured + 10 B
rounded up to 0.01 KB. Every other scenario passes the gate.

Co-Authored-By: Claude... (continued)

790 of 1090 branches covered (72.48%)

Branch coverage included in aggregate %.

1125 of 1362 relevant lines covered (82.6%)

29.94 hits per line