mozilla-releng / balrog / #5788

91%

main: 91%

Pull #3932

circleci

fix(ui): don't sum required signoffs across matching entries

When a rule matches multiple Required Signoffs (eg: a rule with no
channel), the rule view added up signoffs_required for each role, so a
Widevine rule matching three channels that each need 1 releng + 1 relman
showed "3 members of releng, 3 members of relman". The backend requires
the largest count per role, not the sum.

The rules list had a related bug where the last matching entry won
instead of the largest.

Factor the computation into getRequiredSignoffsForRule, use it in both
views, and add tests.

2236 of 2606 branches covered (85.8%)

Branch coverage included in aggregate %.

5896 of 6377 relevant lines covered (92.46%)

0.92 hits per line