supabase / supabase-swift / 41051547105

96%

Build Type

push

github

Committed by web-flow

Commit Message

feat(supabase)!: retry a data request rejected for a stale token once, with the current token or after one refresh (#1634)

* feat(supabase)!: retry a 401 on data requests once with the current token or after one refresh

SupabaseClient now signs PostgREST, Storage, and Functions requests with an
internal AuthMiddleware. On a 401, a request signed with an older token is
sent again with the current one. A request signed with the current token
triggers one deduplicated refreshSession() and is sent again once. A failed
refresh, a second 401, a single-pass body, a per-call Authorization header,
and a request without a session return the response unchanged. Third-party
accessToken mode keeps AccessTokenMiddleware.

BREAKING CHANGE: a data request that gets a 401 is retried once, for every
HTTP method, after a refresh when needed.

Fixes SDK-2064

* test(supabase): cover the stale-token retry for Storage, another user, cancellation and Functions

Storage answers an expired JWT with 400, so the 401-only retry never fires
for it. A retry after another user signed in sends the request as that user.
Functions with a third-party provider that returns the new-format key now
sends that key as the bearer. These tests fail until the fix that follows.

* fix(supabase): retry Storage's expired-token 400 and never retry as another user

Storage answers an expired JWT with 400, the same status and body shape it
uses for an RLS denial. Each service now sets a StaleTokenRejection on the
middleware: PostgREST and Functions keep any 401, and Storage counts a 400
only when the token sent is past its exp claim. No body is read.

A retry now goes out only when the stored or refreshed session belongs to
the same user as the token sent, so a sign-in during the request cannot
turn a write into the new user's write.

Functions in third-party accessToken mode maps the provider's token through
functionsBearerToken again, so a provider that returns the new-format key
sends no bearer.... (continued)

Coverage Stats

93 of 93 new or added lines in 2 files covered. (100.0%)

5 existing lines in 2 files now uncovered.

13324 of 14174 relevant lines covered (94.0%)

588291.28 hits per line