stacklok / toolhive / 41032628931

73%

Build Type

push

github

Committed by web-flow

Commit Message

Answer /health from the health monitor's last check (#7001)

Answer /health from the monitor's last check

The transparent proxy answered every /health request by pinging the backend while the request waited, so a backend slow to answer GET / held the answer for up to the 5 s ping timeout.
The operator's startup and readiness probes time out after 3 s and its liveness probe after 5 s, so such a backend failed the probes and the kubelet restarted a proxy whose backend was alive.
With health checks enabled, the health checker now records the result of each background monitor check, and /health answers from the last one without pinging.
Until the first check completes, /health reports the proxy as healthy without the mcp member.
The monitor checks once when it starts and on every tick, also before the MCP server is initialized, and still counts failures toward shutdown only after initialization.
The HTTP-SSE and streamable proxies keep building their answer per request, because their checks never wait on a backend.

Signed-off-by: Aleksandr Filippov <71711753+alex-feel@users.noreply.github.com>

Coverage Stats

41 of 41 new or added lines in 2 files covered. (100.0%)

10 existing lines in 2 files now uncovered.

91177 of 126390 relevant lines covered (72.14%)

130.04 hits per line