solidjs / solid / 41023668099

78%

main: 89%

push

github

fix(web): a stylesheet removed after its grace releases the gate waiting on it (#4442)

acquireAsset's release removes the element 100 ms later. A mount inside
that grace (a useHead stylesheet under <Loading>) warms the same registry
entry, finds the element still connected and still loading, and gates on
its load. When the grace ran out first, the element was removed before it
loaded; a removed link fires neither load nor error, so the gate waited
forever and the boundary stayed on its fallback.

trackAssetLoad keeps the load's settle on the entry, and the removal
settles a pending load the way an error does. The gate's retry warms the
sheet again on a new entry and waits on the new element.

The same race made served-error-no-reask.spec.tsx's stylesheet case fail
locally whenever the [streamed] run warmed the sheet inside the grace of
the [loaded] run's release.

790 of 1090 branches covered (72.48%)

Branch coverage included in aggregate %.

1125 of 1362 relevant lines covered (82.6%)

29.77 hits per line