solidjs / solid / 41022902905

78%

main: 89%

push

github

fix(h): merge selector classes with a getter class prop instead of throwing (#4424)

A component that forwards its props to a selector-class element
(props => h("button.btn", props)) receives a reactive class as a getter.
Merging it with the static classes spread the accessor descriptor and
added a value, so Object.defineProperties threw "Invalid property
descriptor. Cannot both specify accessors and a value or writable
attribute". A hand-written get class() on h("div.card", ...) threw the
same way.

Drop get/set from the descriptor and read the getter through the props
object, so the existing function path turns the merged class into a
getter that stays reactive.

790 of 1088 branches covered (72.61%)

Branch coverage included in aggregate %.

1125 of 1359 relevant lines covered (82.78%)

29.96 hits per line