• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

kubeflow / trainer / 40970331554
81%

Build:
DEFAULT BRANCH: master
Ran 29 Oct 2026 11:07PM UTC
Jobs 1
Files 46
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

29 Oct 2026 11:02PM UTC coverage: 77.536% (+0.2%) from 77.376%
40970331554

push

github

web-flow
feat(framework): validate Volumes, VolumeMounts, and Tolerations in RuntimePatches (#3961)

* feat(framework): validate Volumes, VolumeMounts, and Tolerations in RuntimePatches

This commit implements validation logic for Volumes, VolumeMounts, and
Tolerations in TrainJob RuntimePatches as requested in the TODO comment.

Changes:
- Removed TODO comment from jobset.go line 174
- Added validation for duplicate volume names
- Added validation for empty volume names
- Added validation for volumeMounts referencing non-existent volumes
- Added validation for empty mountPaths in volumeMounts
- Added validation for duplicate mountPaths within same container
- Added validation for toleration operators (Equal/Exists only)
- Added validation for toleration effects (NoSchedule/PreferNoSchedule/NoExecute)
- Added validation for Equal operator requiring value when key is specified
- Validation applies to both InitContainers and Containers

Tests:
- Added 10 comprehensive test cases covering all validation scenarios
- All existing tests continue to pass (38 total test cases)

The implementation follows existing code patterns using sets.New[string]()
for duplicate detection and field.Invalid() for error reporting.

Signed-off-by: Prateek Rai <prateekrai903@gmail.com>

* refactor: validate RuntimePatches after merge, remove duplicate checks

Changes based on mentor feedback:

Per-patch validation (ensure resources exist in template):
- Validate ReplicatedJob exists in runtime template
- Validate Container exists in runtime template
- Validate InitContainer exists in runtime template
- Validate no envs for reserved containers

Merged validation (after all patches applied):
- VolumeMount references existing volumes (after merge)
- VolumeMount mountPath is not empty
- Toleration operator is valid (Equal/Exists)
- Toleration effect is valid (NoSchedule/PreferNoSchedule/NoExecute)
- Toleration with Equal operator has value when key specified

Removed validations (handled b... (continued)

55 of 62 new or added lines in 1 file covered. (88.71%)

3417 of 4407 relevant lines covered (77.54%)

0.78 hits per line

Uncovered Changes

Lines Coverage ∆ File
7
79.65
1.65% pkg/runtime/framework/plugins/jobset/jobset.go
Jobs
ID Job ID Ran Files Coverage
1 40970331554.1 29 Oct 2026 11:07PM UTC 46
77.54
GitHub Action Run
Source Files on build 40970331554
  • Tree
  • List 46
  • Changed 1
  • Source Changed 0
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • a5ea455d on github
  • Prev Build on master (#40861367070)
  • Next Build on master (#41069424345)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc