solidjs / solid / 40917865309

78%

main: 89%

Build Type

push

github

Committed by web-flow

Commit Message

fix(solid): a truncated fragment's fresh render computes what the server never sent (#4414)

When a stream is cut before a <Loading> fragment settles, the boundary
renders the fragment fresh and adopts the server's records by id
(#4319). The truncation sweep removed the records that can no longer
settle from the registry only a macrotask after DOMContentLoaded, while
the fresh render runs in the microtasks right after it. The render
found those records, adopted their pending promises and waited on them
forever: the boundary kept its fallback and its async reads never ran.

At DOMContentLoaded the sweep now deletes those records first, before
any fragment is marked truncated, so the fresh render computes them.
Values and errors the server sent before the cut are still adopted.
Refs a keyed consumer already took are still rejected a macrotask
later, as before.

Coverage Stats

790 of 1088 branches covered (72.61%)

Branch coverage included in aggregate %.

0 of 13 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

1125 of 1359 relevant lines covered (82.78%)

30.0 hits per line