python-useful-helpers / exec-helpers / 40903400574

89%

Build Type

push

github

Committed by web-flow

Commit Message

Fix SFTP after close, harden SSH and Subprocess execution, enforce the lint baseline (#174)

* Format pyproject.toml with pyproject-fmt

Formatter output only, so the next change shows only real edits to it:

- Tables and keys are reordered and sorted by the tool.
- Lists of values are sorted where order does not matter.
- No value is added, removed or changed.

* Update static checkers and enforce the lint baseline

Raise the checker floors to the current releases and bring the project up to
the baseline rule set. ruff and pyproject-fmt revs in pre-commit match the
dependency groups; CI installs pylint and mypy from the same groups.

- Enable the D (pydocstyle) and PIE rules; fix the docstrings they report.
  Tests ignore only the missing-docstring rules D1.
- Fix ICN001 (datetime imported as dt), FURB107 and BLE001 (narrow noqa with
  a reason), pylint arguments-differ against Callable and a useless
  suppression.
- Suppress S602 on Subprocess.Popen: running a shell command line is the
  purpose of the class (approved by the maintainer).
- Add types-paramiko, types-psutil and types-pyyaml to the mypy group
  instead of --install-types; drop the psutil ignore_missing_imports.
- Enable mypy ignore-without-code; strict comes from [tool.mypy], not flags.
- Fix the "ommands" typo in the bandit tox env, so bandit now actually runs.
- Remove the unused [tool.isort], the wheel build requirement, the dangling
  pep257 tox env, and options that restate a default.

| what | from | to |
| --- | --- | --- |
| ruff | >=0.15.13 | >=0.17.3 |
| mypy | >=2.1 | >=2.4.1 |
| pylint | >=4.0.5 | >=4.1.3 |
| pyproject-fmt | >=2.21.2 | >=2.30.3 |
| prek | >=0.4.1 | >=0.5.7 |
| ruff-pre-commit rev | v0.15.13 | v0.17.3 |
| pyproject-fmt rev | v2.21.2 | v2.30.3 |
| CI pylint | >=3.0.0 | dependency group |

* Restore a closed SSH session before opening SFTP

SSHClient closes the paramiko client on the outermost context exit (and on
reconnect()), leaving it without a transport. ... (continued)

Coverage Stats

230 of 438 branches covered (52.51%)

Branch coverage included in aggregate %.

160 of 169 new or added lines in 10 files covered. (94.67%)

2 existing lines in 2 files now uncovered.

1347 of 1897 relevant lines covered (71.01%)

5.68 hits per line