gookit / validate / 40861688826

91%

Build Type

push

github

Committed by inhere

Commit Message

feat(validate): support a slice value in the in/not_in rules

The enum rules handed the whole slice to Enum, whose conversion to a basic type
fails, so `in:go,php` on a []string always failed and `not_in:go,php` always passed,
whatever the elements (#266).

- Enum walks every element of a slice/array: the value is in the enum when each
  element is. A nil element pointer is ignored.
- NotIn is not the plain inverse for a slice: no element may be in the enum, so
  `not_in:go,php` rejects ["go","java"] instead of accepting it.
- scalar values keep the old behaviour, and NotIn stays the inverse of Enum for them.

Also documents the string semantics of the numeric comparators: `min`/`max`
(`gt`/`gte`/`lt`/`lte`/`between`) compare a string value lexicographically, not by
length, so `min:3` passes for "ab" and fails for "1". `min_len`/`max_len` are the
length rules. The code comments said "string" for some of them and nothing for the
others; the README rows now spell it out and a test pins the behaviour.

Tests: enum with slices/arrays/pointer elements on both rules, the tag level
`in`/`not_in` on a []string and a []int, and the string comparison of min/max. The
two existing tests that pinned the old whole-slice behaviour are updated.

Coverage Stats

29 of 35 new or added lines in 1 file covered. (82.86%)

1 existing line in 1 file now uncovered.

4253 of 4666 relevant lines covered (91.15%)

5.97 hits per line