supabase / mcp / 40855634865

98%

push

github

test(mcp-server-supabase): make the generatePassword symbols test deterministic (#501)

## What kind of change does this PR introduce?

Test fix (flaky test). Test-only, one file, no package or changelog
impact.

## What is the current behavior?

`should generate a password with symbols` in
`packages/mcp-server-supabase/src/password.test.ts` is flaky. It failed
the Tests job on #500 and passed on rerun.

The test calls `generatePassword({ symbols: true })` and asserts at
least one symbol. That draws 10 characters uniformly from letters +
symbols, and nothing guarantees a symbol appears. The regex also had
`/-=` inside the character class, which is a range from `/` to `=`, so
digits counted as symbols and a literal `-` didn't. Together that makes
it fail about 1.4% of runs: (53/81)^10, where 53 is the 52 letters plus
`-`.

## What is the new behavior?

The test disables letters, like the existing `with numbers` test already
does, and asserts no character is a letter or digit. It can't fail by
chance any more, and it fails on every run if the symbols option adds
nothing or adds letters or digits instead of symbols.

I fixed the test and left `generatePassword` alone. Its only production
caller is `createProject`, which generates a 16-character `db_pass` from
letters and numbers and never enables symbols. The Management API types
give `db_pass` as a plain string with no character-class rule. So the
options choose which sets to draw from without promising that each set
appears, and changing the generator would change behavior that nothing
depends on.

## Verification

`pnpm --filter @supabase/mcp-server-supabase exec vitest run
src/password.test.ts` passes, and repeat runs stay green. Mutating
`generatePassword` so the symbols option adds nothing, or adds uppercase
letters or digits instead of symbols, fails the test on every run.

1064 of 1121 branches covered (94.92%)

Branch coverage included in aggregate %.

5662 of 5769 relevant lines covered (98.15%)

169.18 hits per line