newAM / idasen / 40819411615

89%

master: 89%

push

github

fix: reset moving state when move_to_target is cancelled or fails

`move_to_target` set `_moving = False` only after `await self._move_task`
returned normally. When the caller was cancelled, or `do_move` raised
(for example a `BleakError`), the flag stayed `True` and `_move_task`
pointed at a dead task.

Afterwards `move_to_target` returned with "Already moving" without
moving, and `stop()` awaited the cancelled task and re-raised the
cancellation. A consumer that cancels an in-flight move to request a new
target, such as Home Assistant automations in `restart` mode, could
never move the desk again until it reconnected.

Reset `_moving` and `_move_task` in a `finally` block.

7 of 7 new or added lines in 1 file covered. (100.0%)

357 of 401 relevant lines covered (89.03%)

4.45 hits per line