solidjs / solid / 40788807619

78%

main: 89%

push

github

fix(signals): a frame node re-run outside its hold re-derives the readers of the staging it replaces (#4378) (#4390)

* fix(signals): a frame node re-run outside its hold re-derives the readers of the staging it replaces (#4378)

A reader recreated in the flush that clears an upstream error, under
Errored > Loading, waits on the async memo's flight, so the frame holds and
the error boundary's output stages its content with it. The rejection then
re-runs the output outside that transaction's flush: it publishes mainline
(#3404), back to the fallback it had committed. That is no change, so
nothing re-derived its reader, and the landing applied the reader's held
run of the superseded content: an empty hole with nothing in flight.

The mainline re-pass now marks its subscribers when it supersedes a staging,
so readers of that staging re-derive on the value it publishes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* chore(size): ledger for #4378 (+16 B minified)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* chore(size): ledger for #4378 (+16 B minified), over next @ 40cde2cd

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* fix(signals): move the #4378 re-derive into the boundary's redraw so the floors don't pay

The insertSubs in recompute's mainline-publish arm cost +16 B minified on
every scenario, the frozen floors and hello world included. The case is a
boundary's output: a redraw re-derives it outside the hold that staged its
content, and it publishes the committed fallback back unchanged. The
redraw now marks the output's readers when the output carries a staging,
so they re-derive with it. boundaries.ts is tree-shaken from builds without
a boundary.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropi... (continued)

790 of 1084 branches covered (72.88%)

Branch coverage included in aggregate %.

1125 of 1355 relevant lines covered (83.03%)

29.96 hits per line