openconfig / ygot / 40786854168

89%

master: 89%

Build Type

Pull #1124

github

Committed by robshakir

Commit Message

yreflect, util, gogen: optimise RangeOrderedMap and Walk node traversal

- Cache GoOrderedMap reflection method indices and key/value types per
  reflect.Type in internal/yreflect.
- Update RangeOrderedMap to short-circuit on empty maps and iterate over
  batch Keys() and Values() slices rather than invoking Get(k) via
  reflection for every element.
- Pre-allocate Values() slice capacity in gogen ordered map templates and
  return nil on empty maps.
- Make *util.NodeInfo implement util.WalkNode directly so
  WalkNodeFromNodeInfo returns ni without allocating a walkNodeInfo
  wrapper struct on every visited node.
- Reuse a shared leafMemo and avoid boxing child visitors on scalar leaf
  nodes in forEachFieldMemoVisitor.

Pull Request Pull Request #1124: yreflect, util, gogen: optimise RangeOrderedMap and Walk node traversal

Coverage Stats

117 of 161 new or added lines in 4 files covered. (72.67%)

17 existing lines in 1 file now uncovered.

14247 of 16068 relevant lines covered (88.67%)

1529.6 hits per line