solidjs / solid / 40770658394

78%

main: 89%

push

github

fix(signals): a held `on` change's fallback folds back when its readers land in that hold later (#4379) (#4392)

`<Loading on={filter()}>` showed its fallback when a `filter` change held
with an action (D-34, #4336) committed under that action's own
`refresh()`. The re-arm stages the fallback into the hold; its readers
(the rows' `id` holes, an ordinary pending read over the new question)
land inside the same hold a flush later. The seam's fold-back (D-16, U-9)
only ran in the re-arm's own flush (`b._armed`), so the boundary stayed
collecting, the staged fallback committed with the action, and the
refresh's pending, caught by the collecting boundary, kept it up until
the refresh answered. A refresh is quiet (F-9).

The fold-back now runs at any seam: a fallback staged into the hold its
readers landed in is dropped, and the content is ready when the hold
commits (D-15). The closed-only case passed only because its answer
dropped the rows (their effects died).

Tests: signals `loading-on-held-filter-refresh-4379.test.ts` (toggle and
same-rows forms fail on next), web `loading-on-held-filter-refresh-4379.spec.tsx`
(the issue's four on x toggle combos; on=true toggle=true fails on next).
Size: -5 B minified on every boundary scenario, floors unchanged.


Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

Co-authored-by: Claude <noreply@anthropic.com>

788 of 1081 branches covered (72.9%)

Branch coverage included in aggregate %.

1124 of 1354 relevant lines covered (83.01%)

29.97 hits per line