Tatsh / smlab / 40770637146

100%

push

github

project: address review on kick placement and tempo refinement

- README: label the reference-set results as measured on the charts
  the kick thresholds were tuned on, not a held-out evaluation.
- CHANGELOG: add a Changed section for song_features, refine_offset and
  predict_phase.
- Restore the em dashes rewritten in the README, the BAND_EDGES
  docstring and the tempo.py history paragraph. The tempo.py precision
  paragraph stays rewritten because its content changed.
- KICK_LAG_SECONDS: describe the lag as the peak trailing the authored
  beat, which is what kick_phase subtracts.
- kick_phase: drop the params argument, since its constants are only
  calibrated at the default onset settings.
- stems.cache: keep CUDA or the CPU for the training cache. Only
  generation was checked on MPS.

Signed-off-by: David Skoland <davidskoland@gmail.com>

834 of 834 branches covered (100.0%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 2 files covered. (100.0%)

4052 of 4052 relevant lines covered (100.0%)

3.0 hits per line