• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

tari-project / tari / 40754488439
79%

Build:
DEFAULT BRANCH: development
Ran 28 Oct 2026 09:09PM UTC
Jobs 1
Files 799
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

28 Oct 2026 07:27PM UTC coverage: 76.971% (-0.1%) from 77.114%
40754488439

push

github

web-flow
fix(chain-storage): require a sorted body before treating it as the one its header commits to (#8193)

`inputs_and_outputs_match_header` builds coinbase and non-coinbase
outputs into separate MMRs, so `block_output_mr` does not fix how the
two are interleaved. A body with its coinbase in another position
therefore matched the header's roots. It then failed
`UnsortedOrDuplicateOutput` during validation, and the block's hash was
recorded in `bad_blocks` even though the block as mined is valid.

A body now only matches its header if its roots match and its inputs,
outputs and kernels are each sorted and unique, the same rule as
`check_sorting_and_duplicates`. A body that doesn't match is treated as
before: the sending peer is banned through `InvalidFullBlock` /
`MismatchedMmrRoots`, and the block is not recorded as bad. This changes
no consensus rule.

Known residual: a block whose body was mined out of canonical order
(already invalid) is no longer recorded in `bad_blocks`. Each peer that
serves it is banned instead.

Tests cover the match rule, block propagation, block sync and the reorg
path.

🤖 Generated with [Claude Code](https://claude.com/claude-code)


<!-- greptile_comment -->

<!-- greptile_summary -->

<h2><a
href="https://app.greptile.com/api/retrigger?id=89735523"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/RetriggerDark.svg?v=2"><source
media="(prefers-color-scheme: light)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2"><img
alt="Retrigger"
src="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2"
align="right"></picture></a><a
href="https://app.greptile.com/tari-project/github/tari-project/tari/-/pull/8193?utm_source=greptile_review&amp;utm_medium=github&amp;utm_campaign=view_in_greptile"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/ViewInGre... (continued)

6 of 6 new or added lines in 1 file covered. (100.0%)

353 existing lines in 16 files now uncovered.

138181 of 179524 relevant lines covered (76.97%)

301140.98 hits per line

Coverage Regressions

Lines Coverage ∆ File
270
63.69
-3.17% base_layer/core/src/chain_storage/blockchain_database.rs
38
57.64
-0.8% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
9
64.79
-2.66% base_layer/core/src/chain_storage/db_transaction.rs
6
92.42
-1.23% comms/dht/src/outbound/broadcast.rs
5
87.45
-0.49% base_layer/core/src/proof_of_work/cuckaroo_pow.rs
3
98.98
-0.76% base_layer/core/src/consensus/base_node_consensus_manager.rs
3
76.97
-0.36% base_layer/core/src/test_helpers/blockchain.rs
3
75.27
-3.23% base_layer/core/src/validation/mocks.rs
3
78.09
0.14% comms/core/src/connectivity/manager.rs
3
67.57
-8.11% comms/core/src/peer_manager/error.rs
3
81.25
-4.69% comms/core/src/pipeline/outbound.rs
2
73.22
0.14% base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
2
80.66
-0.21% comms/dht/src/connectivity/mod.rs
1
81.5
-0.16% base_layer/core/src/chain_storage/lmdb_db/lmdb.rs
1
77.43
0.0% base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
1
93.23
-0.38% comms/core/src/connectivity/proactive_dialer.rs
Jobs
ID Job ID Ran Files Coverage
1 40754488439.1 28 Oct 2026 09:09PM UTC 799
76.97
GitHub Action Run
Source Files on build 40754488439
  • Tree
  • List 799
  • Changed 23
  • Source Changed 1
  • Coverage Changed 23
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #40754488439
  • 3dcd9e66 on github
  • Prev Build on development (#40691582512)
  • Next Build on development (#40791459365)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc