FlexMeasures / flexmeasures / 40764997029

87%

push

github

Fix assets paging without a sort order skipping assets (#2583)

* Fix assets paging without a sort order skipping assets

GET /api/v3_0/assets applied its ORDER BY only when both sort_by and
sort_dir were given, and neither branch had a unique tie-breaker, so
Postgres was free to return rows in whatever order each query plan
produced. Walking LIMIT/OFFSET pages then showed some assets twice and
never showed others.

The query now always appends GenericAsset.id as the final ORDER BY
column, which is unique, so every page break falls on a stable boundary
(#2572). The default sort direction stays a separate decision.

Signed-off-by: niukanen1 <57656076+niukanen1@users.noreply.github.com>

* Order by id when sort_by is unsupported, move ordering notes to docstring

Also adds a regression test that asserts the compiled ORDER BY when
sort_by is not a supported field, with and without search terms.

Signed-off-by: niukanen1 <57656076+niukanen1@users.noreply.github.com>

---------

Signed-off-by: niukanen1 <57656076+niukanen1@users.noreply.github.com>

5 of 5 new or added lines in 1 file covered. (100.0%)

22810 of 26175 relevant lines covered (87.14%)

0.87 hits per line