openconfig / ygot / 40759102021

89%

master: 89%

Build Type

Pull #1122

github

Committed by robshakir

Commit Message

ygot: cache parsed struct-tag paths and module prefixes during rendering

Cache reflection field metadata, parsed path and shadow-path segments, and
RFC7951 module prefixes per reflect.Type and reflect.StructTag to reduce
allocations during JSON and gNMI rendering.

- Type and tag caches: Add structTypeInfoCache and structTagInfoCache in
  ygot/struct_validation_map.go to parse struct tags and reflection flags
  (isAnnotation, isYangPresence, isGoEnum, isYANGEmpty) once per struct type
  and tag.
- Early nil and unset checks: Skip nil pointers, maps, slices, and interfaces,
  unset GoEnum values, and unset YANGEmpty leaves in structJSON and
  findUpdatedLeaves before resolving paths or modules.
- Pre-computed module prefixes: Pre-compute RFC7951 prependmods slices and
  child module names in cachedModuleSet when RewriteModuleNames is empty, and
  use direct string concatenation instead of fmt.Sprintf.
- Slice isolation: Allocate independent gnmiPath backing slices in
  buildGNMIPaths so callers that mutate returned paths cannot corrupt cached
  tag data.
- Tests: Add TestStructTagToLibModules and TestGetStructTypeInfo in
  ygot/struct_validation_map_test.go, and a 5% allocation regression test
  (TestMarshal7951Performance) using testing.AllocsPerRun in
  ygot/render_test.go.

Pull Request Pull Request #1122: ygot: cache parsed struct-tag paths and module prefixes during rendering

Coverage Stats

217 of 225 new or added lines in 2 files covered. (96.44%)

13 existing lines in 1 file now uncovered.

14293 of 16097 relevant lines covered (88.79%)

1605.23 hits per line