openconfig / ygot / 40756473607

89%

master: 89%

Build Type

Pull #1121

github

Committed by robshakir

Commit Message

ytypes, util: optimise ValidateLeafRefData traversal and memo allocations

`ytypes.ValidateLeafRefData` previously traversed schema-only `nil` branches,
allocated a `PathQueryMemo` map on every visited node, and allocated a zero
value via `reflect.New` on each `util.IsValueNilOrDefault` scalar check.

Changes:
- **Skip `nil` data branches**: Add `WithSkipNilData` on `util.WalkOptions` and
  enable it in `util.ForEachField` when `in` is a `*util.PathQueryNodeMemo`.
- **Lazy query memo maps**: Initialise `PathQueryNodeMemo.Memo` to `nil` on
  visited nodes and allocate the map lazily in `ytypes.dataNodesAtPath` when
  caching a query result.
- **Zero-allocation default checks**: Replace `reflect.New` in
  `util.IsValueNilOrDefault` with `reflect.Value.IsZero` after the scalar
  type check.
- **Single map-key slice allocation**: Reuse `nn.FieldKeys` in
  `util.walkFieldInternal` and `util.walkDataFieldInternal` instead of calling
  `reflect.Value.MapKeys` repeatedly.
- **Tests**: Add unit tests in `util/reflect_test.go` and a `5%` allocation
  regression test (`TestValidateLeafRefDataPerformance`) in
  `ytypes/leafref_test.go`.

Pull Request Pull Request #1121: ytypes, util: optimise ValidateLeafRefData traversal and memo allocations

Coverage Stats

40 of 49 new or added lines in 3 files covered. (81.63%)

2 existing lines in 1 file now uncovered.

14188 of 15969 relevant lines covered (88.85%)

1597.57 hits per line