solidjs / solid / 40755124312

78%

main: 89%

push

github

fix(solid,signals): warn about duplicate Solid copies only when they meet (#4370)

* fix(solid): dev duplicate-instance check keyed by major, off v1's Solid$$

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWMMJ6aTSA3MvtgJWG2

* fix(solid): warn about duplicate Solid copies only when they meet

The dev warning used to fire as soon as a second copy loaded, so isolated
copies (a devtools panel in its own root, a Solid 1 copy on the page) warned
with nothing wrong (#2549). Copies now share one Solid$$running slot that
names the copy whose component is running; a component or useContext() from
another copy that runs ownerless inside it warns once. v1's Solid$$ flag is
no longer set. Dev only; prod builds carry none of it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWMMJ6aTSA3MvtgJWG2

* fix(signals): catch reads across duplicate Solid copies

The interaction check only saw components and useContext. The common
duplicate is a library's precompiled JSX (or a runtime that bundled its own
solid-js) whose render effects read the app's props or signals from another
copy: the read finds no listener and silently does not track.

The duplicate-copy slot moves into @solidjs/signals. In dev every
computation run marks its copy, and an untracked signal or store read that
finds another copy running warns once, unless both copies render through
roots of their own (an app calling into an isolated copy's API). Prod builds
carry none of it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWMMJ6aTSA3MvtgJWG2

* perf(signals): same-copy nested runs only read the duplicate-copy slot

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWMMJ6aTSA3MvtgJWG2

* perf(signals): duplicate-copy checks cost nothing while one copy is loaded

Co... (continued)

788 of 1081 branches covered (72.9%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 2 files covered. (100.0%)

1124 of 1354 relevant lines covered (83.01%)

29.82 hits per line